Fixed some issues with labels#22
Open
jamiefolsom wants to merge 1 commit intomit-history:ulaval-design-integrationfrom
Open
Fixed some issues with labels#22jamiefolsom wants to merge 1 commit intomit-history:ulaval-design-integrationfrom
jamiefolsom wants to merge 1 commit intomit-history:ulaval-design-integrationfrom
Conversation
jamiefolsom
force-pushed
the
jf/labels
branch
7 times, most recently
from
16c8d4c to
00f59b5
Compare
Some more fixes to filter labels Update bundle Deal with other empty null filter values Ignore build dir in repo Build and bust cache Remove build from gitignore. Filter out 'NaN' as a filter value Fix close paren Fix test for NaN values. Can't test for non-numeric filter values, since many are (non-numeric) Update bundle
jamiefolsom
force-pushed
the
jf/labels
branch
from
00f59b5 to
819cb9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17
Some of these were issues are with strings in the UI code, others with data.